Fix libomp install on macos - #23907
Merged
Merged
Conversation
luisquintanilla
approved these changes
Apr 23, 2021
luisquintanilla
left a comment
luisquintanilla
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this contribution @ksaur! Looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brew no longer supports installing from github (Homebrew/brew#8791), so we must use a work-around to install libomp on macos.
Describe your changes here.
This PR uses the common workaround to the new limitation of not being able to install straight from github.
Also, the current hash gives 404 (for libmp 7.0.0), this new hash is for a working version of libomp (11.1.0).
Fixes #21225